Skip to content

Commit

Permalink
Remove use of ignored boto3 parameter (#2075)
Browse files Browse the repository at this point in the history
Remove use of ignored boto3 parameter

SUMMARY
get_ec2_security_group_ids_from_names() has ignored the boto3 parameter since release 4.0.0, drop the use.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/glue_connection.py
plugins/modules/autoscaling_launch_config.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
  • Loading branch information
tremble authored Apr 9, 2024
1 parent 6316d6c commit b5d4ea7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions changelogs/fragments/boto3_equals.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
trivial:
- glue_connection - stop passing ``boto3`` into ``get_ec2_security_group_ids_from_names()`` it is no longer used.
- autoscaling_launch_config - stop passing ``boto3`` into ``get_ec2_security_group_ids_from_names()`` it is no longer used.
2 changes: 1 addition & 1 deletion plugins/modules/autoscaling_launch_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ def create_launch_config(connection, module):
module.fail_json_aws(e, msg="Failed to connect to AWS")
try:
security_groups = get_ec2_security_group_ids_from_names(
module.params.get("security_groups"), ec2_connection, vpc_id=vpc_id, boto3=True
module.params.get("security_groups"), ec2_connection, vpc_id=vpc_id
)
except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
module.fail_json_aws(e, msg="Failed to get Security Group IDs")
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/glue_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def create_or_update_glue_connection(connection, connection_ec2, module, glue_co
if module.params.get("security_groups") is not None:
# Get security group IDs from names
security_group_ids = get_ec2_security_group_ids_from_names(
module.params.get("security_groups"), connection_ec2, boto3=True
module.params.get("security_groups"), connection_ec2
)
params["ConnectionInput"]["PhysicalConnectionRequirements"]["SecurityGroupIdList"] = security_group_ids
if module.params.get("subnet_id") is not None:
Expand Down

0 comments on commit b5d4ea7

Please sign in to comment.