Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1001/e965b231 backport][stable-2] Add backoff logic to elb_target_group_info #1005

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 17, 2022

This is a backport of PR #1001 as merged into main (e965b23).

SUMMARY

From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability.

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded
fatal: [10_184_0_132 -> 127.0.0.1]: FAILED! => changed=false 
  boto3_version: 1.20.34
  botocore_version: 1.23.34
  error:
    code: Throttling
    message: Rate exceeded
    type: Sender
  msg: 'Failed to list target groups: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded'
  response_metadata:
    http_headers:
      content-length: '271'
      content-type: text/xml
      date: Wed, 16 Mar 2022 09:50:24 GMT
      x-amzn-requestid: xxxxx
    http_status_code: 400
    max_attempts_reached: true
    request_id: xxxxx
    retry_attempts: 4
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

elb_target_group_info

ADDITIONAL INFORMATION

Add backoff logic to elb_target_group_info

SUMMARY
From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability.
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded
fatal: [10_184_0_132 -> 127.0.0.1]: FAILED! => changed=false
  boto3_version: 1.20.34
  botocore_version: 1.23.34
  error:
    code: Throttling
    message: Rate exceeded
    type: Sender
  msg: 'Failed to list target groups: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded'
  response_metadata:
    http_headers:
      content-length: '271'
      content-type: text/xml
      date: Wed, 16 Mar 2022 09:50:24 GMT
      x-amzn-requestid: xxxxx
    http_status_code: 400
    max_attempts_reached: true
    request_id: xxxxx
    retry_attempts: 4

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
elb_target_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit e965b23)
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) traceback labels Mar 17, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@marknet15
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@marknet15
Copy link
Contributor

@markuman it looks like that tests splitter issue again, I'm wondering if its missing something for this branch

@markuman
Copy link
Member

@markuman it looks like that tests splitter issue again, I'm wondering if its missing something for this branch

I've no idea atm.

@alinabuzachis
Copy link
Contributor

@markuman it looks like that tests splitter issue again, I'm wondering if its missing something for this branch

I've no idea atm.

That's weird. elb_target_group_info has been added in the legacy_missing_tests, so it could probably be something related to the branch version. Let me ask @goneri.

@abikouo
Copy link
Contributor

abikouo commented Mar 23, 2022

recheck

@abikouo
Copy link
Contributor

abikouo commented Mar 23, 2022

@markuman it looks like that tests splitter issue again, I'm wondering if its missing something for this branch

I've no idea atm.

That's weird. elb_target_group_info has been added in the legacy_missing_tests, so it could probably be something related to the branch version. Let me ask @goneri.

The way the splitter is working here is expected, so you need to backport this #986 if you want the splitter to work as expected.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

closing for the benefit of #1015

@markuman markuman closed this Mar 25, 2022
@tremble tremble deleted the patchback/backports/stable-2/e965b2319edf7ffe40b1cf6a7002119c129979e3/pr-1001 branch July 7, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review module module new_contributor Help guide this first time contributor plugins plugin (any type) traceback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants