-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1001/e965b231 backport][stable-2] Add backoff logic to elb_target_group_info #1005
Conversation
Add backoff logic to elb_target_group_info SUMMARY From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability. An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded fatal: [10_184_0_132 -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Failed to list target groups: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: content-length: '271' content-type: text/xml date: Wed, 16 Mar 2022 09:50:24 GMT x-amzn-requestid: xxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_target_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit e965b23)
recheck |
recheck |
recheck |
recheck |
recheck |
recheck |
@markuman it looks like that tests splitter issue again, I'm wondering if its missing something for this branch |
I've no idea atm. |
recheck |
The way the splitter is working here is expected, so you need to backport this #986 if you want the splitter to work as expected. |
closing for the benefit of #1015 |
This is a backport of PR #1001 as merged into main (e965b23).
SUMMARY
From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability.
ISSUE TYPE
COMPONENT NAME
elb_target_group_info
ADDITIONAL INFORMATION