Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fake integration suite including an aliases file listing every … #1011

Conversation

alinabuzachis
Copy link
Contributor

…module name with missing integration tests. (#986)

Prevent CI to be run for whole collection when modules without integration tests are modified

Add a fake integration suite including an aliases file listing every module name with missing integration tests.
This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped).
Add some of the modules in the aliases files where it makes more sense.
SUMMARY

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

…module name with missing integration tests. (ansible-collections#986)

Prevent CI to be run for whole collection when modules without integration tests are modified

Add a fake integration suite including an aliases file listing every module name with missing integration tests.
This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped).
Add some of the modules in the aliases files where it makes more sense.
SUMMARY


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) tests tests labels Mar 23, 2022
@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Mar 24, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f7e51f0 into ansible-collections:stable-2 Mar 24, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…e_rds_instance

Migrate rds_instance* modules and tests

Depends-On: ansible/zuul-config#443
Migrate rds_instance* modules and tests

Reviewed-by: Jill R <None>
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Bikouo Aubin <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants