Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup_sshkey: drop a dep on Crypto #2004

Merged
merged 1 commit into from
Nov 16, 2023
Merged

setup_sshkey: drop a dep on Crypto #2004

merged 1 commit into from
Nov 16, 2023

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Nov 16, 2023

SUMMARY

Adjust ec2-fingerprint.py so it use cryptography instead of the deprecated Crypto library.

(originally written by Gonéri)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tests/integration/targets/setup_sshkey/files/ec2-fingerprint.py

ADDITIONAL INFORMATION

Original PR (amazon.aws)
ansible-collections/amazon.aws#799

@tremble
setup_sshkey: drop a dep on Crypto
b262bd3 
Adjust ec2-fingerprint.py so it use cryptography instead of the deprecated Crypto library.
@tremble tremble marked this pull request as ready for review November 16, 2023 13:28
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/05891c0ee3c74d9fb2a4b28464ef77f0

❌ ansible-galaxy-importer FAILURE in 5m 40s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 06s
✔️ ansible-test-splitter SUCCESS in 5m 34s
Skipped 22 jobs

@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-7 PR should be backported to the stable-7 branch labels Nov 16, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f8bdd870536c4ff29f2321c49cee569a

❌ ansible-galaxy-importer FAILURE in 5m 18s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 58s
✔️ ansible-test-splitter SUCCESS in 5m 45s
Skipped 22 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 42c0475 into ansible-collections:main Nov 16, 2023
87 of 102 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 16, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/42c0475d1c6a65c3a9b5180fa3a5df6db863f0ef/pr-2004

Backported as #2005

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 16, 2023
@tremble @patchback
setup_sshkey: drop a dep on Crypto (#2004)
6eed090 
setup_sshkey: drop a dep on Crypto

SUMMARY
Adjust ec2-fingerprint.py so it use cryptography instead of the deprecated Crypto library.
(originally written by Gonéri)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets/setup_sshkey/files/ec2-fingerprint.py
ADDITIONAL INFORMATION
Original PR (amazon.aws)
ansible-collections/amazon.aws#799

Reviewed-by: Alina Buzachis
(cherry picked from commit 42c0475)
@patchback patchback bot mentioned this pull request Nov 16, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 16, 2023
@patchback
setup_sshkey: drop a dep on Crypto (#2004) (#2005)
8aef2be 
[PR #2004/42c0475d backport][stable-7] setup_sshkey: drop a dep on Crypto

This is a backport of PR #2004 as merged into main (42c0475).
SUMMARY
Adjust ec2-fingerprint.py so it use cryptography instead of the deprecated Crypto library.
(originally written by Gonéri)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets/setup_sshkey/files/ec2-fingerprint.py
ADDITIONAL INFORMATION
Original PR (amazon.aws)
ansible-collections/amazon.aws#799

Reviewed-by: Mark Chappell
@tremble tremble deleted the pycrypto branch January 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @alinabuzachis