Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example of eks_nodegroup #2028

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Dec 31, 2023

SUMMARY

When using the example as a reference, ansible-playbook command outputs the following errors:

fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'scaling_config' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'labels' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "value of capacity_type must be one of: ON_DEMAND, SPOT, got: on_demand"}

This fixes those issues.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

eks_nodegroup

ADDITIONAL INFORMATION

When using the example as a reference, ansible-playbook command outputs the following errors:

fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'scaling_config' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'labels' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "value of capacity_type must be one of: ON_DEMAND, SPOT, got: on_demand"}

This fixes those issues.
Copy link

github-actions bot commented Dec 31, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e22fb8a71b54463f89b96f100786f63a

ansible-galaxy-importer FAILURE in 5m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 36s
✔️ ansible-test-splitter SUCCESS in 5m 41s
✔️ integration-community.aws-1 SUCCESS in 26m 17s
Skipped 21 jobs

@alinabuzachis alinabuzachis added backport-7 PR should be backported to the stable-7 branch backport-6 PR should be backported to the stable-6 branch labels Jan 4, 2024
@tremble tremble added skip-changelog mergeit Merge the PR (SoftwareFactory) labels Jan 4, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/535df49bb73c4c4d909083ea1b3dc1bf

ansible-galaxy-importer FAILURE in 4m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 09s
✔️ ansible-test-splitter SUCCESS in 5m 20s
✔️ integration-community.aws-1 SUCCESS in 25m 41s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit bfd1d80 into ansible-collections:main Jan 4, 2024
92 of 105 checks passed
Copy link

patchback bot commented Jan 4, 2024

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/bfd1d80b6aae496a97e4e0f7fcee2a8f9438116e/pr-2028

Backported as #2034

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2024
Fix example of eks_nodegroup

SUMMARY
When using the example as a reference, ansible-playbook command outputs the following errors:
fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'scaling_config' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'labels' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "value of capacity_type must be one of: ON_DEMAND, SPOT, got: on_demand"}

This fixes those issues.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
(cherry picked from commit bfd1d80)
Copy link

patchback bot commented Jan 4, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/bfd1d80b6aae496a97e4e0f7fcee2a8f9438116e/pr-2028

Backported as #2035

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2024
Fix example of eks_nodegroup

SUMMARY
When using the example as a reference, ansible-playbook command outputs the following errors:
fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'scaling_config' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'labels' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "value of capacity_type must be one of: ON_DEMAND, SPOT, got: on_demand"}

This fixes those issues.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
(cherry picked from commit bfd1d80)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 5, 2024
[PR #2028/bfd1d80b backport][stable-7] Fix example of eks_nodegroup

This is a backport of PR #2028 as merged into main (bfd1d80).
SUMMARY
When using the example as a reference, ansible-playbook command outputs the following errors:
fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'scaling_config' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "argument 'labels' is of type <class 'list'> and we were unable to convert to dict: <class 'list'> cannot be converted to a dict"}

fatal: [localhost]: FAILED! => {"changed": false, "msg": "value of capacity_type must be one of: ON_DEMAND, SPOT, got: on_demand"}

This fixes those issues.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@oomichi oomichi deleted the oomichi-patch-1 branch January 6, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory) skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants