Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #2075/b5d4ea70 backport][stable-7] Remove use of ignored boto3 parameter #2076

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/boto3_equals.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
trivial:
- glue_connection - stop passing ``boto3`` into ``get_ec2_security_group_ids_from_names()`` it is no longer used.
- autoscaling_launch_config - stop passing ``boto3`` into ``get_ec2_security_group_ids_from_names()`` it is no longer used.
2 changes: 1 addition & 1 deletion plugins/modules/autoscaling_launch_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ def create_launch_config(connection, module):
module.fail_json_aws(e, msg="Failed to connect to AWS")
try:
security_groups = get_ec2_security_group_ids_from_names(
module.params.get("security_groups"), ec2_connection, vpc_id=vpc_id, boto3=True
module.params.get("security_groups"), ec2_connection, vpc_id=vpc_id
)
except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
module.fail_json_aws(e, msg="Failed to get Security Group IDs")
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/glue_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def create_or_update_glue_connection(connection, connection_ec2, module, glue_co
if module.params.get("security_groups") is not None:
# Get security group IDs from names
security_group_ids = get_ec2_security_group_ids_from_names(
module.params.get("security_groups"), connection_ec2, boto3=True
module.params.get("security_groups"), connection_ec2
)
params["ConnectionInput"]["PhysicalConnectionRequirements"]["SecurityGroupIdList"] = security_group_ids
if module.params.get("subnet_id") is not None:
Expand Down
Loading