Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ELB target integration test #2078

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Fix ELB target integration test #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e45026b
Fix ELB target integration test
tremble Apr 14, 2024
9d0e452
black
tremble Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions plugins/modules/glue_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,7 @@ def create_or_update_glue_connection(connection, connection_ec2, module, glue_co
params["ConnectionInput"]["PhysicalConnectionRequirements"] = dict()
if module.params.get("security_groups") is not None:
# Get security group IDs from names
security_group_ids = get_ec2_security_group_ids_from_names(
module.params.get("security_groups"), connection_ec2
)
security_group_ids = get_ec2_security_group_ids_from_names(module.params.get("security_groups"), connection_ec2)
params["ConnectionInput"]["PhysicalConnectionRequirements"]["SecurityGroupIdList"] = security_group_ids
if module.params.get("subnet_id") is not None:
params["ConnectionInput"]["PhysicalConnectionRequirements"]["SubnetId"] = module.params.get("subnet_id")
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/targets/elb_target/tasks/lambda_target.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
state: present
zip_file: /tmp/lambda.zip
runtime: python3.12
role: "{{ ROLE_ARN.arn }}"
role: "{{ ROLE_ARN.iam_role.arn }}"
handler: ansible_lambda_target.lambda_handler
timeout: 30
register: lambda_function
Expand Down
Loading