Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken SES integration tests #2198

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 30, 2024

SUMMARY

It would appear that Amazon now provides a window, during which a deleted SES identity can be revived (even if marked as deleted). This resulted in some of our integration tests breaking. The identities were still marked as "deleted", AWS just revived them...

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ses_identity

ADDITIONAL INFORMATION

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d7d8d58518274e228f298fe033059891

ansible-galaxy-importer FAILURE in 4m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 30s
✔️ ansible-test-splitter SUCCESS in 4m 02s
✔️ integration-community.aws-1 SUCCESS in 10m 21s
Skipped 21 jobs

@alinabuzachis alinabuzachis added mergeit Merge the PR (SoftwareFactory) backport-9 labels Oct 30, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0cab3cbc912c46d2a6909fe49e29451d

ansible-galaxy-importer FAILURE in 4m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 02s
✔️ ansible-test-splitter SUCCESS in 3m 54s
✔️ integration-community.aws-1 SUCCESS in 12m 14s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3a71abd into ansible-collections:main Oct 30, 2024
67 of 96 checks passed
Copy link

patchback bot commented Oct 30, 2024

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/3a71abd0e10ff994af4a2c4f5c08f839cafedfa2/pr-2198

Backported as #2199

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 30, 2024
SUMMARY
It would appear that Amazon now provides a window, during which a deleted SES identity can be revived (even if marked as deleted).  This resulted in some of our integration tests breaking.  The identities were still marked as "deleted", AWS just revived them...
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ses_identity
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 3a71abd)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 30, 2024
This is a backport of PR #2198 as merged into main (3a71abd).
SUMMARY
It would appear that Amazon now provides a window, during which a deleted SES identity can be revived (even if marked as deleted).  This resulted in some of our integration tests breaking.  The identities were still marked as "deleted", AWS just revived them...
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ses_identity
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 mergeit Merge the PR (SoftwareFactory) skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants