Fix unit tests #2212
Fix unit tests #2212
Conversation
There was a problem hiding this comment.
You can move the fixture to the conftest.py file like I did here
https://github.com/ansible-collections/community.aws/pull/2211/files#diff-2061d2675ad59dc75b2892a0a098a2cc32fc01911feaecabfe2fd02e3497d957
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 35s (non-voting) |
pytest was refusing to find them when I tried. I wanted to get a "quickfix" in and then have a larger cleanup of the unit tests as a follow-up |
|
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 5m 19s (non-voting) |
softwarefactory-project-zuul
bot
merged commit 959855c
into
ansible-collections:main
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #2213 🤖 @patchback |
SUMMARY Quick fix for unit test failures following ansible-collections/amazon.aws#2444 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin (cherry picked from commit 959855c)
SUMMARY As discussed in #2212 cleans up the unit tests to move importing some of the fixtures into conftest.py tox configs needed a little cleanup to ensure that things were consistently in the import path. ISSUE TYPE Feature Pull Request COMPONENT NAME pyproject.toml tests/unit/conftest.py tests/unit/plugins/ tox.ini ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin
SUMMARY
Quick fix for unit test failures following ansible-collections/amazon.aws#2444
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION