Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CI to be run for whole collection when modules without integration tests are modified #986

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Prevent CI to be run for whole collection when modules without integration tests are modified #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/integration/targets/aws_waf_web_acl/aliases
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ aws_waf_info
aws_waf_web_acl
aws_waf_web_match
aws_waf_web_rule
aws_waf_condition
aws_waf_rule
2 changes: 2 additions & 0 deletions tests/integration/targets/ec2_asg/aliases
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@

slow
cloud/aws

ec2_asg_info
1 change: 1 addition & 0 deletions tests/integration/targets/ecs_cluster/aliases
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ unsupported

cloud/aws

ecs_service
ecs_service_info
ecs_task
ecs_taskdefinition
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/targets/elb_instance/aliases
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
cloud/aws

elb_classic_lb_info
5 changes: 5 additions & 0 deletions tests/integration/targets/legacy_missing_tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Fake integration suite

This is a fake integration suite including an aliases file listing every module name with missing integration tests.

This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped).
41 changes: 41 additions & 0 deletions tests/integration/targets/legacy_missing_tests/aliases
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
disabled

# Modules that do not have test suites
aws_application_scaling_policy
aws_batch_compute_environment
aws_batch_job_definition
aws_batch_job_queue
aws_direct_connect_confirm_connection
aws_direct_connect_connection
aws_direct_connect_gateway
aws_direct_connect_link_aggregation_group
aws_direct_connect_virtual_interface
aws_s3_cors
aws_sgw_info
cloudfront_info
cloudfront_invalidation
cloudfront_origin_access_identity
cloudwatchevent_rule
cloudwatchlogs_log_group_info
data_pipeline
dynamodb_ttl
ec2_ami_copy
ec2_asg_lifecycle_hook
ec2_customer_gateway
ec2_customer_gateway_info
ec2_snapshot_copy
ec2_vpc_vgw_info
ec2_win_password
ecs_attribute
elasticache_info
elasticache_parameter_group
elasticache_snapshot
elb_target_group_info
iam_mfa_device_info
lambda_event
rds_instance_snapshot
rds_snapshot_info
redshift_cross_region_snapshots
s3_website
sts_session_token
ec2_vpc_vpn