-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ANSIBLE_METADATA #339
Remove ANSIBLE_METADATA #339
Conversation
@Andersson007 This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
Is the ANSIBLE_METADATA not required anymore? Do you have a link to a documentation of what we need to take into account when writing new modules/plugins? I have an open PR for a new module and probably would need to clean it up as it was created based on rules from Ansible 2.7 |
@martinm82 ansible-collections/overview#45 (comment) |
ready_for_review |
sorry, guys, i thought it's only for modules. Now i grepped through the whole content. When CI passed, it's ready for review |
@martinm82 ansible-collections/overview#45 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Felix reviewed to etc3, I reviewed the rest.
Thanks for doing this!
@Andersson007 Thank you for doing this |
@gundalow @felixfontein @resmo thanks for reviewing and merging |
If we ever need this, here's a list of modules which were marked as
|
SUMMARY
Remove ANSIBLE_METADATA
ISSUE TYPE