dashboard: Fail if the target directory does not exist

Previously, this would 'succeed' but the dashboard would not be added.

changelogs/fragments/1.2.2.yml

@@ -0,0 +1,4 @@
+bugfixes:
+- grafana_dashboard now explicitely fails if the folder doesn't exist upon creation.
+  It would previously silently pass but not create the dashboard.
+  (https://github.com/ansible-collections/community.grafana/issues/153)

plugins/modules/grafana_dashboard.py

@@ -340,10 +340,7 @@ def grafana_create_dashboard(module, data):
     if grafana_version >= 5:
         folder_exists, folder_id = grafana_folder_exists(module, data['grafana_url'], data['folder'], headers)
         if folder_exists is False:
-            result['msg'] = "Dashboard folder '%s' does not exist." % data['folder']
-            result['uid'] = uid
-            result['changed'] = False
-            return result
+            raise GrafanaAPIException("Dashboard folder '%s' does not exist." % data['folder'])
 
         payload['folderId'] = folder_id
 
@@ -385,10 +382,6 @@ def grafana_create_dashboard(module, data):
             result['msg'] = "Dashboard %s unchanged." % payload['dashboard']['title']
             result['changed'] = False
     else:
-        # create
-        if folder_exists is True:
-            payload['folderId'] = folder_id
-
         # Ensure there is no id in payload
         if 'id' in payload['dashboard']:
             del payload['dashboard']['id']

tests/integration/targets/grafana_dashboard/tasks/dashboard-folder-destination.yml

@@ -0,0 +1,33 @@
+---
+- name: copy dashboard file
+  copy:
+    src: "files/dashboard.json"
+    dest: "/tmp/dashboard.json"
+
+- block:
+  - name: Check import grafana dashboard from file to unknown folder fails
+    grafana_dashboard:
+      grafana_url: "{{ grafana_url }}"
+      grafana_user: "{{ grafana_username }}"
+      grafana_password: "{{ grafana_password }}"
+      state: present
+      commit_message: Updated by ansible
+      path: /tmp/dashboard.json
+      overwrite: true
+      folder: inexistent
+    register: result
+    ignore_errors: true
+
+- debug:
+    var: result
+
+- set_fact:
+    # XXX: Too many quotes of different types to do inline.
+    #      I did not manage to find a good way of having it inline.
+    expected_error: "error : Dashboard folder 'inexistent' does not exist."
+
+- assert:
+    that:
+      - "result.changed == false"
+      - "result.failed == true"
+      - "result.msg == expected_error"

tests/integration/targets/grafana_dashboard/tasks/main.yml

@@ -3,3 +3,4 @@
   - include: delete-dashboard.yml
   - include: dashboard-from-id.yml
   - include: dashboard-from-file.yml
+  - include: dashboard-folder-destination.yml