Skip to content

Commit

Permalink
Merge branch 'main' into test/update-cleanup-sanity
Browse files Browse the repository at this point in the history
  • Loading branch information
Nemental authored May 28, 2024
2 parents b9bd233 + 125308e commit bd1d684
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
3 changes: 3 additions & 0 deletions changelogs/fragments/372-rm-dashboard-message-argument.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
removed_features:
- removed deprecated `message` argument in `grafana_dashboard`
17 changes: 1 addition & 16 deletions plugins/modules/grafana_dashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@
description:
- Set a commit message for the version history.
- Only used when C(state) is C(present).
- C(message) alias is deprecated in Ansible 2.10, since it is used internally by Ansible Core Engine.
aliases: [ 'message' ]
type: str
extends_documentation_fragment:
- community.grafana.basic_auth
Expand Down Expand Up @@ -620,15 +618,7 @@ def main():
dashboard_id=dict(type="str"),
dashboard_revision=dict(type="str", default="1"),
overwrite=dict(type="bool", default=False),
commit_message=dict(
type="str",
aliases=["message"],
deprecated_aliases=[
dict(
name="message", version="2.0.0", collection_name="community.grafana"
)
],
),
commit_message=dict(type="str"),
)
module = AnsibleModule(
argument_spec=argument_spec,
Expand All @@ -647,11 +637,6 @@ def main():

module.params["url"] = clean_url(module.params["url"])

if "message" in module.params:
module.fail_json(
msg="'message' is reserved keyword, please change this parameter to 'commit_message'"
)

try:
if module.params["state"] == "present":
result = grafana_create_dashboard(module, module.params)
Expand Down

0 comments on commit bd1d684

Please sign in to comment.