-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana_team: unable to use spaces or other utf-8 chars in name/title #169
Conversation
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage ? 72.54%
=======================================
Files ? 7
Lines ? 703
Branches ? 75
=======================================
Hits ? 510
Misses ? 176
Partials ? 17 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CWollinger !
Patch is ok but could you update the changelog fragment for 1.1.2 ?
See this PR for info : #166
let me know if you need help
Hey @rrey I added 2 lines to the 1.2.2.yml file. Hope this is ok... It is possible to rebase because of the PR conflict? |
Yes you have to rebase ! |
@CWollinger I try to avoid merge commits to have a clean linear history, could you rebase your branch without merge commit ? |
SUMMARY
grafana_team: unable to use spaces or other utf-8 chars in name/title
Same PR like for grafana_folder #79
Fix issue #164
ISSUE TYPE
COMPONENT NAME
grafana_team
ANSIBLE VERSION
CONFIGURATION
OS / ENVIRONMENT
Ubuntu 18.04.3 LTS
STEPS TO REPRODUCE
Procedure described in : #164
EXPECTED RESULTS
Teams should be created.
ACTUAL RESULTS
Error, because not URL quote for the get_folder API query.