Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana_team: unable to use spaces or other utf-8 chars in name/title #169

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

CWollinger
Copy link
Contributor

SUMMARY

grafana_team: unable to use spaces or other utf-8 chars in name/title

Same PR like for grafana_folder #79

Fix issue #164

ISSUE TYPE
  • Bug Report
COMPONENT NAME

grafana_team

ANSIBLE VERSION
ansible 2.9.15
  config file = /mnt/c/DeveloperArea/Telia/moncap-repo/ansible.cfg
  configured module search path = ['/home/myuser/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.9/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.9.0 (default, Oct  6 2020, 00:00:00) [GCC 10.2.1 20200826 (Red Hat 10.2.1-3)]

collection:
community.grafana 1.2.1
CONFIGURATION

OS / ENVIRONMENT

Ubuntu 18.04.3 LTS

STEPS TO REPRODUCE

Procedure described in : #164

EXPECTED RESULTS

Teams should be created.

ACTUAL RESULTS

Error, because not URL quote for the get_folder API query.

msg": "Grafana Folders API answered with HTTP -1"

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@5f72a4d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage        ?   72.54%           
=======================================
  Files           ?        7           
  Lines           ?      703           
  Branches        ?       75           
=======================================
  Hits            ?      510           
  Misses          ?      176           
  Partials        ?       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f72a4d...4be4f2d. Read the comment docs.

Copy link
Collaborator

@rrey rrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CWollinger !
Patch is ok but could you update the changelog fragment for 1.1.2 ?
See this PR for info : #166

let me know if you need help

@CWollinger CWollinger changed the title grafana_team: unable to use spaces or other utf-8 chars in name/title grafana_folder: unable to use spaces or other utf-8 chars in name/title Apr 27, 2021
@CWollinger CWollinger changed the title grafana_folder: unable to use spaces or other utf-8 chars in name/title grafana_team: unable to use spaces or other utf-8 chars in name/title Apr 27, 2021
@CWollinger
Copy link
Contributor Author

Hey @rrey

I added 2 lines to the 1.2.2.yml file. Hope this is ok...

It is possible to rebase because of the PR conflict?

@rrey
Copy link
Collaborator

rrey commented Apr 27, 2021

Yes you have to rebase !

@rrey
Copy link
Collaborator

rrey commented Apr 28, 2021

@CWollinger I try to avoid merge commits to have a clean linear history, could you rebase your branch without merge commit ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants