Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alertmanager Grafana datasource #287

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

jgosmann
Copy link
Contributor

SUMMARY

This adds the "alertmanager" datasource. Apparently added in Grafana 9.2.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

grafana_datasource plugin

@rrey
Copy link
Collaborator

rrey commented Oct 30, 2022

Hi @jgosmann,

Please add integration tests and a changelog fragment to ha e CI pass.

thx 🙏🏻 !

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #287 (cef4115) into main (324fcf7) will increase coverage by 3.49%.
The diff coverage is 0.00%.

❗ Current head cef4115 differs from pull request most recent head 9f8a264. Consider uploading reports for the commit 9f8a264 to get more accurate results

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   70.31%   73.80%   +3.49%     
==========================================
  Files          17       13       -4     
  Lines        1772     1596     -176     
  Branches      294      275      -19     
==========================================
- Hits         1246     1178      -68     
+ Misses        389      281     -108     
  Partials      137      137              
Flag Coverage Δ
integration 68.36% <0.00%> (-0.10%) ⬇️
sanity ?
units 65.69% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/grafana_datasource.py 75.13% <0.00%> (-0.81%) ⬇️
plugins/modules/grafana_plugin.py 25.47% <0.00%> (-2.84%) ⬇️
plugins/modules/grafana_organization.py 83.33% <0.00%> (-1.18%) ⬇️
plugins/modules/grafana_folder.py 74.74% <0.00%> (-1.02%) ⬇️
plugins/modules/grafana_notification_channel.py 57.07% <0.00%> (-0.49%) ⬇️
plugins/modules/grafana_dashboard.py 51.76% <0.00%> (-0.40%) ⬇️
plugins/lookup/grafana_dashboard.py
plugins/doc_fragments/basic_auth.py
plugins/doc_fragments/api_key.py
plugins/callback/grafana_annotations.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BenjaminSchubert
Copy link
Contributor

Hey, I'd be interested in being able to do this too. I see the tests were added but the PR has become stale. Is there any hope of resurrecting this PR @jgosmann or one of the maintainers? Or would it be best to create a new one?

@jgosmann
Copy link
Contributor Author

jgosmann commented Aug 9, 2024

I don't think there's anything I can do at the moment. Still waiting for a review. 😅

Copy link
Contributor

@BenjaminSchubert BenjaminSchubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not a maintainer, mainly trying to help :) )

The code seems consistent with the other implementations of data sources, I also tried it locally and it did work as I expected. There are conflicts that will need rebasing though

@Nemental
Copy link
Collaborator

Nemental commented Aug 9, 2024

Hey @jgosmann,
I've resolved the conflicts and made a few other small changes.
Tomorrow I'll do the final review and take a look over the tests, it's just too late for that now.
Many thanks for the PR and your contribution!

@Nemental Nemental enabled auto-merge (rebase) August 16, 2024 07:26
Copy link
Collaborator

@Nemental Nemental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @jgosmann

@Nemental Nemental merged commit 9cf46a3 into ansible-collections:main Aug 16, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants