-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alertmanager Grafana datasource #287
Conversation
Hi @jgosmann, Please add integration tests and a changelog fragment to ha e CI pass. thx 🙏🏻 ! |
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 70.31% 73.80% +3.49%
==========================================
Files 17 13 -4
Lines 1772 1596 -176
Branches 294 275 -19
==========================================
- Hits 1246 1178 -68
+ Misses 389 281 -108
Partials 137 137
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hey, I'd be interested in being able to do this too. I see the tests were added but the PR has become stale. Is there any hope of resurrecting this PR @jgosmann or one of the maintainers? Or would it be best to create a new one? |
I don't think there's anything I can do at the moment. Still waiting for a review. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not a maintainer, mainly trying to help :) )
The code seems consistent with the other implementations of data sources, I also tried it locally and it did work as I expected. There are conflicts that will need rebasing though
Hey @jgosmann, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @jgosmann
SUMMARY
This adds the "alertmanager" datasource. Apparently added in Grafana 9.2.
ISSUE TYPE
COMPONENT NAME
grafana_datasource plugin