Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting #324

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Formatting #324

merged 3 commits into from
Jan 4, 2024

Conversation

rndmh3ro
Copy link
Collaborator

SUMMARY
  • Format with black
  • remove unused variables
ISSUE TYPE
  • Bugfix Pull Request
    t
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 324 lines in your changes are missing coverage. Please review.

Comparison is base (c4da526) 70.98% compared to head (e3a8c73) 70.98%.

Files Patch % Lines
plugins/modules/grafana_notification_channel.py 39.16% 46 Missing and 41 partials ⚠️
plugins/modules/grafana_dashboard.py 45.65% 51 Missing and 24 partials ⚠️
plugins/modules/grafana_plugin.py 17.02% 39 Missing ⚠️
plugins/modules/grafana_datasource.py 70.40% 22 Missing and 15 partials ⚠️
plugins/lookup/grafana_dashboard.py 13.15% 27 Missing and 6 partials ⚠️
plugins/callback/grafana_annotations.py 17.39% 19 Missing ⚠️
plugins/modules/grafana_folder.py 61.11% 5 Missing and 2 partials ⚠️
plugins/modules/grafana_organization_user.py 80.00% 2 Missing and 5 partials ⚠️
.../modules/grafana/grafana_team/test_grafana_team.py 92.18% 5 Missing ⚠️
plugins/modules/grafana_organization.py 75.00% 3 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   70.98%   70.98%           
=======================================
  Files          18       18           
  Lines        1875     1875           
  Branches      325      325           
=======================================
  Hits         1331     1331           
  Misses        399      399           
  Partials      145      145           
Flag Coverage Δ
integration 69.69% <54.94%> (ø)
sanity 23.58% <9.71%> (ø)
units 65.59% <47.36%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nemental Nemental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Nice unified structure and the code is much more readable in many places. Maybe we should reference black in the README?

@rndmh3ro rndmh3ro merged commit db35d14 into ansible-collections:main Jan 4, 2024
19 of 20 checks passed
@rndmh3ro rndmh3ro deleted the formatting branch January 4, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants