try run tests in check-mode, too #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 70.79% 70.84% +0.05%
==========================================
Files 18 18
Lines 1883 1883
Branches 327 327
==========================================
+ Hits 1333 1334 +1
Misses 405 405
+ Partials 145 144 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rndmh3ro
force-pushed
the
test_checkmode
branch
3 times, most recently
from
adf6a37 to
d3f5817
Compare
Nemental
approved these changes
Jan 4, 2024
tests/integration/targets/grafana_notification_channel/site.yml
Outdated
Show resolved
Hide resolved
when a runme.sh exists in the test-path, it will be run. then the roles will be run in check-mode and normal-mode to test if they work in check mode (at least somewhat)
rndmh3ro
force-pushed
the
test_checkmode
branch
from
e9cf1aa to
3690867
Compare
Nemental
requested changes
Jan 4, 2024
tests/integration/targets/grafana_organization_user/tasks/main.yml
Outdated
Show resolved
Hide resolved
Nemental
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
when a runme.sh exists in the test-path, it will be run. then the roles will be run in check-mode and normal-mode to test if they work in check mode (at least somewhat)
ISSUE TYPE