Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): manage datasources by org_name #332

Merged
merged 11 commits into from
Jan 4, 2024
Merged

feat(datasource): manage datasources by org_name #332

merged 11 commits into from
Jan 4, 2024

Conversation

Nemental
Copy link
Collaborator

@Nemental Nemental commented Dec 1, 2023

SUMMARY

Like #318 and #331, but for grafana_datasource :)
Instead of specifying org_id, you can use org_name...

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module: grafana_datasource

ADDITIONAL INFORMATION

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (db35d14) 70.98% compared to head (b21be5f) 70.79%.

Files Patch % Lines
plugins/modules/grafana_datasource.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   70.98%   70.79%   -0.20%     
==========================================
  Files          18       18              
  Lines        1875     1883       +8     
  Branches      325      327       +2     
==========================================
+ Hits         1331     1333       +2     
- Misses        399      405       +6     
  Partials      145      145              
Flag Coverage Δ
integration 69.39% <40.00%> (-0.31%) ⬇️
sanity 23.52% <20.00%> (-0.07%) ⬇️
units 65.15% <20.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nemental Nemental marked this pull request as ready for review December 1, 2023 12:47
@Nemental Nemental requested review from rrey and seuf as code owners December 1, 2023 12:47
@Nemental Nemental self-assigned this Jan 2, 2024
@Nemental Nemental requested a review from rndmh3ro January 2, 2024 10:06
Copy link
Collaborator

@rndmh3ro rndmh3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I left some possible improvements.

plugins/modules/grafana_datasource.py Outdated Show resolved Hide resolved
plugins/modules/grafana_datasource.py Outdated Show resolved Hide resolved
plugins/modules/grafana_datasource.py Outdated Show resolved Hide resolved
plugins/modules/grafana_datasource.py Outdated Show resolved Hide resolved
@Nemental
Copy link
Collaborator Author

Nemental commented Jan 3, 2024

@rndmh3ro great improvements! Thank you 🚀
Didn't know about the list comprehension, nice 👍

Currently on GitHub mobile app, have to check the results of the workflows later (as I can see it's an indentation error)

@Nemental Nemental requested a review from rndmh3ro January 4, 2024 08:13
@Nemental Nemental merged commit 2907e93 into ansible-collections:main Jan 4, 2024
17 of 20 checks passed
@Nemental Nemental deleted the feat/datasource-by-org-name branch January 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants