-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource): manage datasources by org_name #332
feat(datasource): manage datasources by org_name #332
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 70.98% 70.79% -0.20%
==========================================
Files 18 18
Lines 1875 1883 +8
Branches 325 327 +2
==========================================
+ Hits 1331 1333 +2
- Misses 399 405 +6
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I left some possible improvements.
@rndmh3ro great improvements! Thank you 🚀 Currently on GitHub mobile app, have to check the results of the workflows later (as I can see it's an indentation error) |
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
SUMMARY
Like #318 and #331, but for
grafana_datasource
:)Instead of specifying
org_id
, you can useorg_name
...ISSUE TYPE
COMPONENT NAME
module: grafana_datasource
ADDITIONAL INFORMATION