Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: telekom-mms.grafana role #343

Merged
merged 98 commits into from
Jan 22, 2024
Merged

feat: telekom-mms.grafana role #343

merged 98 commits into from
Jan 22, 2024

Conversation

Nemental
Copy link
Collaborator

@Nemental Nemental commented Jan 16, 2024

SUMMARY

Resolves #340

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (195f9d1) 70.82% compared to head (b07a263) 70.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   70.82%   70.82%           
=======================================
  Files          18       18           
  Lines        1878     1878           
  Branches      326      326           
=======================================
  Hits         1330     1330           
  Misses        404      404           
  Partials      144      144           
Flag Coverage Δ
integration 69.45% <ø> (ø)
sanity 23.53% <ø> (ø)
units 65.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nemental Nemental force-pushed the feat/telekom-mms-role branch from 2a213c0 to 0db7a5b Compare January 16, 2024 09:51
@Nemental Nemental self-assigned this Jan 16, 2024
@Nemental Nemental changed the title feat: telekom-mms.grafan role feat: telekom-mms.grafana role Jan 16, 2024
@Nemental Nemental force-pushed the feat/telekom-mms-role branch from 4b34e84 to a7eec86 Compare January 19, 2024 09:56
@Nemental Nemental requested a review from rndmh3ro January 19, 2024 11:55
@Nemental Nemental marked this pull request as ready for review January 19, 2024 11:55
@Nemental Nemental requested review from rrey and seuf as code owners January 19, 2024 11:55
Copy link
Collaborator

@rndmh3ro rndmh3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

I've left two questions to ponder.

changelogs/fragments/343-telekom-mms-role.yml Outdated Show resolved Hide resolved
roles/grafana/CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge telekom-mms.grafana into community.grafana
4 participants