Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana_folder): manage folders for organizations #347

Merged
merged 11 commits into from
Feb 7, 2024

Conversation

Nemental
Copy link
Collaborator

@Nemental Nemental commented Feb 7, 2024

SUMMARY
  • manage folders for organizations
  • small doc fixes (code syntax)
ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f9c2e88) 71.17% compared to head (a851fd6) 71.18%.

Files Patch % Lines
plugins/modules/grafana_folder.py 83.33% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   71.17%   71.18%           
=======================================
  Files          18       18           
  Lines        1887     1898   +11     
  Branches      330      332    +2     
=======================================
+ Hits         1343     1351    +8     
- Misses        401      402    +1     
- Partials      143      145    +2     
Flag Coverage Δ
integration 70.04% <83.33%> (+0.02%) ⬆️
sanity 23.22% <27.77%> (-0.18%) ⬇️
units 65.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nemental Nemental marked this pull request as ready for review February 7, 2024 09:45
@Nemental Nemental requested review from rrey and seuf as code owners February 7, 2024 09:45
@Nemental Nemental requested review from rndmh3ro and removed request for seuf and rrey February 7, 2024 09:45
@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Feb 7, 2024

lgtm!

@Nemental Nemental merged commit f8a0970 into main Feb 7, 2024
31 checks passed
@Nemental Nemental deleted the feature/folder-organization branch February 7, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants