Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace deprecated TestCase.assertEquals #350

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Feb 20, 2024

SUMMARY

TestCase.assertEquals is depracated and removed in Python 3.12.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test

@bdrung bdrung requested review from rrey and seuf as code owners February 20, 2024 13:49
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6773070) 71.18% compared to head (c25dfb3) 71.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files          18       18           
  Lines        1898     1898           
  Branches      332      332           
=======================================
  Hits         1351     1351           
  Misses        402      402           
  Partials      145      145           
Flag Coverage Δ
integration 70.04% <ø> (ø)
sanity 23.22% <ø> (ø)
units 65.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rndmh3ro
Copy link
Collaborator

Thanks!

Can you please add a changelog-fragment? Otherwise this PR is fine.

`TestCase.assertEquals` is depracated and removed in Python 3.12.

Signed-off-by: Benjamin Drung <[email protected]>
@bdrung
Copy link
Contributor Author

bdrung commented Feb 20, 2024

Added changelogs/fragments/350-python3.12.yml (hopefully in the right format).

@rndmh3ro rndmh3ro merged commit 25d56be into ansible-collections:main Feb 20, 2024
31 checks passed
@bdrung bdrung deleted the python3.12 branch February 20, 2024 15:49
cjwatson added a commit to cjwatson/community.grafana that referenced this pull request Oct 29, 2024
`TestCase.assertEquals` was deprecated and removed in Python 3.12.

Similar to ansible-collections#350, but for code that was added later.
cjwatson added a commit to cjwatson/community.grafana that referenced this pull request Oct 29, 2024
`TestCase.assertEquals` was deprecated and removed in Python 3.12.

Similar to ansible-collections#350, but for code that was added later.
Nemental pushed a commit that referenced this pull request Oct 29, 2024
`TestCase.assertEquals` was deprecated and removed in Python 3.12.

Similar to #350, but for code that was added later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants