Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add module grafana_contact_point #352

Merged
merged 54 commits into from
May 30, 2024
Merged

Conversation

Nemental
Copy link
Collaborator

SUMMARY

New module for management of contact points, introduced with the new Grafana Unified Alerting in Grafana 8.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 73.21429% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 74.44%. Comparing base (101d40c) to head (9175486).
Report is 14 commits behind head on main.

Current head 9175486 differs from pull request most recent head eff27c7

Please upload reports for the commit eff27c7 to get more accurate results.

Files Patch % Lines
plugins/modules/grafana_contact_point.py 73.21% 18 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   72.00%   74.44%   +2.43%     
==========================================
  Files          20       15       -5     
  Lines        2097     1831     -266     
  Branches      356      340      -16     
==========================================
- Hits         1510     1363     -147     
+ Misses        431      311     -120     
- Partials      156      157       +1     
Flag Coverage Δ
integration 70.23% <72.32%> (-0.46%) ⬇️
sanity ?
units 65.18% <ø> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nemental Nemental requested a review from rndmh3ro March 21, 2024 20:11
@Nemental
Copy link
Collaborator Author

@rndmh3ro I don't think it's ready to merge but maybe it's time for a first review :) Maybe you have some time take a look.
Next I want to do the documentation of the arguments in module file, so please ignore this for the moment :D

@Nemental Nemental force-pushed the feature/contact-points branch from 31afbec to fa5ce76 Compare May 27, 2024 08:39
@Nemental Nemental marked this pull request as ready for review May 28, 2024 11:43
@Nemental Nemental requested review from rrey and seuf as code owners May 28, 2024 11:43
@Nemental
Copy link
Collaborator Author

@rndmh3ro finally ready to review 🎉 hopefully the tests are enough, I can't see it anymore 🫨

plugins/modules/grafana_contact_point.py Outdated Show resolved Hide resolved
@Nemental Nemental enabled auto-merge (rebase) May 30, 2024 11:43
@Nemental Nemental merged commit fff9558 into main May 30, 2024
29 checks passed
@Nemental Nemental deleted the feature/contact-points branch May 30, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants