-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix get latest grafana versions python script #354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 71.18% 74.46% +3.28%
==========================================
Files 18 14 -4
Lines 1898 1719 -179
Branches 332 312 -20
==========================================
- Hits 1351 1280 -71
+ Misses 402 293 -109
- Partials 145 146 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried to run the script and got an error:
Traceback (most recent call last):
File "/Users/remirey/dev/ansible_collections/community/grafana/hacking/find_grafana_versions.py", line 30, in <module>
major, version, as_tuple = get_by_major(release.get("tag_name"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/remirey/dev/ansible_collections/community/grafana/hacking/find_grafana_versions.py", line 10, in get_by_major
return int(version.split(".")[0]), version, tuple(map(int, version.split(".")))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '0-preview'
They released a preview right after my changes to the python script :D Now all pre-release (-) and build-release tags (+) are skipped according to the semantic version |
failed sanity workflow is fixed in #355 |
lgtm |
SUMMARY
10.0.13 (as_int: 10013) > 10.2.6 (as_int: 1026)
(older version is higher)10.0.13 (as_tulpe: (10, 0, 13)) < 10.2.6 (as_tulpe: (10, 2, 6))
(newer version is higher)ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
before:
after: