Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set umask when installing plugins #362

Merged

Conversation

dhoffend
Copy link
Contributor

SUMMARY

Set umask when installing plugins Otherwise system defaults could make the plugin unaccessible for the grafana user.

Fixes #361

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.grafana.grafana_plugin

Otherwise system defaults could make the plugin unaccessible for the grafana user.

Fixes ansible-collections#361
@dhoffend dhoffend requested review from rrey and seuf as code owners April 30, 2024 10:22
@Nemental
Copy link
Collaborator

Hey @dhoffend :)
Thanks for your contribution! Can you please add a changelog fragment?

Copy link
Collaborator

@Nemental Nemental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks @dhoffend 🚀

@Nemental Nemental merged commit 3c05865 into ansible-collections:main May 2, 2024
28 of 29 checks passed
@dhoffend
Copy link
Contributor Author

dhoffend commented May 2, 2024

Thanks @Nemental I saw your changelog request too late

@dhoffend dhoffend deleted the plugin-install-set-umask branch May 2, 2024 08:55
@Nemental
Copy link
Collaborator

Nemental commented May 2, 2024

@dhoffend no problem ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin not usable when system umask is set to umask 027
2 participants