Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grafana_datasource): handling of desired default state #364

Merged
merged 7 commits into from
May 8, 2024
Merged

fix(grafana_datasource): handling of desired default state #364

merged 7 commits into from
May 8, 2024

Conversation

Nemental
Copy link
Collaborator

@Nemental Nemental commented Apr 30, 2024 •
edited
Loading

SUMMARY
  1. Fixes Create first datasource non-default #363
  2. postgresql: change plugin id grafana/grafana#77444 remove type from diff if postgres because of new plugin id (otherwise integration workflows fail for grafana > 10.2.3)
ISSUE TYPE
  • Bugfixes
  • Tests
COMPONENT NAME
ADDITIONAL INFORMATION

@Nemental Nemental marked this pull request as ready for review April 30, 2024 13:20
@Nemental Nemental requested review from rrey and seuf as code owners April 30, 2024 13:20
@Nemental Nemental requested a review from rndmh3ro April 30, 2024 14:12
@Nemental Nemental mentioned this pull request Apr 30, 2024
Merged
@Nemental Nemental merged commit c831311 into main May 8, 2024
29 checks passed
@Nemental Nemental deleted the fix/first-datasource-non-default branch May 8, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndmh3ro rndmh3ro rndmh3ro approved these changes

@rrey rrey Awaiting requested review from rrey rrey is a code owner

@seuf seuf Awaiting requested review from seuf seuf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create first datasource non-default
2 participants
@Nemental @rndmh3ro