feat(grafana_folder): support sub folders #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rndmh3ro whats the problem with https://github.com/ansible-collections/community.grafana/actions/runs/9759739949/job/26937382647?pr=381#step:3:2642 ? I can't figure it out... |
Just got this in the matrix ansible-channel: |
|
Great, thank you! So it can be merged as it's not a problem related to the PR...? |
rndmh3ro
reviewed
Jul 2, 2024
I forgot to send my comments. But in general - yes, this is an unrelated problem and the PR is great. :) I've left some small remarks that you can check. |
Co-authored-by: Sebastian Gumprich <[email protected]>
rndmh3ro
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #380
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION