Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grafana_notification_channel): deprecation #382

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

Nemental
Copy link
Collaborator

@Nemental Nemental commented Jun 27, 2024

SUMMARY
  • Fixes integration test workflows for Grafana v11 coming with Bump Grafana versions #377
  • Deprecate module grafana_notification_channel (legacy alerting removed with Grafana v11)
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.91%. Comparing base (fff9558) to head (9f94c10).
Report is 13 commits behind head on main.

Current head 9f94c10 differs from pull request most recent head 4557305

Please upload reports for the commit 4557305 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #382       +/-   ##
===========================================
+ Coverage   45.63%   63.91%   +18.28%     
===========================================
  Files          21       16        -5     
  Lines        2220     1735      -485     
  Branches      433      369       -64     
===========================================
+ Hits         1013     1109       +96     
+ Misses       1167      454      -713     
- Partials       40      172      +132     
Flag Coverage Δ
integration 70.42% <ø> (?)
sanity 23.45% <ø> (+0.05%) ⬆️
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nemental Nemental force-pushed the fix/deprecate-notification-channel branch from 7e79653 to b7f7746 Compare June 27, 2024 12:33
@Nemental Nemental marked this pull request as ready for review June 28, 2024 10:28
@Nemental Nemental requested review from rrey and seuf as code owners June 28, 2024 10:28
@Nemental Nemental requested review from rndmh3ro and removed request for seuf and rrey June 28, 2024 10:28
@Nemental Nemental enabled auto-merge (rebase) June 28, 2024 10:28
@Nemental Nemental merged commit 6bb5266 into main Jul 2, 2024
29 checks passed
@Nemental Nemental deleted the fix/deprecate-notification-channel branch July 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants