Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana_datasource): add tls_servername argument #395

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Nemental
Copy link
Collaborator

SUMMARY

Fixes #389

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@Nemental Nemental requested review from rrey and seuf as code owners August 12, 2024 11:58
@Nemental Nemental requested review from rndmh3ro and removed request for seuf and rrey August 12, 2024 11:58
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (fff9558) to head (bc4a74d).
Report is 58 commits behind head on main.

Files Patch % Lines
plugins/modules/grafana_datasource.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #395       +/-   ##
===========================================
+ Coverage   45.63%   64.28%   +18.65%     
===========================================
  Files          21       16        -5     
  Lines        2220     1753      -467     
  Branches      433      377       -56     
===========================================
+ Hits         1013     1127      +114     
+ Misses       1167      452      -715     
- Partials       40      174      +134     
Flag Coverage Δ
integration 70.51% <0.00%> (?)
sanity 23.21% <0.00%> (-0.19%) ⬇️
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rndmh3ro rndmh3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Nemental Nemental merged commit 3eb4135 into main Aug 12, 2024
30 of 31 checks passed
@Nemental Nemental deleted the feat/datasource-tls-servername branch August 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[datasource] Missing serverName when using mTLS for Loki backend
2 participants