Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grafana_datasource): remove field apiVersion from return of current datasource #396

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Nemental
Copy link
Collaborator

@Nemental Nemental commented Aug 12, 2024

SUMMARY

Remove the apiVersion field from the return of the current datasource so that the comparison of the current and the new datasource works.
Fixes #377 - broken grafana_datasource integration tests in grafana major version 11

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@Nemental Nemental requested review from rrey and seuf as code owners August 12, 2024 12:12
@Nemental Nemental requested review from rndmh3ro and removed request for seuf and rrey August 12, 2024 12:12
Copy link
Collaborator

@rrey rrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nemental Nemental merged commit 08b849e into main Aug 12, 2024
29 checks passed
@Nemental Nemental deleted the fix/datasource-diff-apiversion branch August 12, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants