Update grafana_silence.py #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using Grafana Cloud and version is 11.3.0-75221. The function is not able to fetch major.minor.rev due to error " ValueError: invalid literal for int() with base 10"
|
This breaks for grafana oss-versions, where there is no build-number. This needs to be fixed. We also use this function in multiple modules, not only the silence-module, e.g. here. https://github.com/ansible-collections/community.grafana/blob/main/plugins/modules/grafana_notification_channel.py#L646 So this needs to be fixed everywhere. We should also move this function to the module-utils, but if you don't feel comfortable doing this, there is no need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I am using Grafana Cloud and version is 11.3.0-75221. The get version function is not able to fetch major, minor, rev due to error " ValueError: invalid literal for int() with base 10"
ISSUE TYPE
COMPONENT NAME
grafana_silence