Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1886 - failure_detection is reported as 'link_status_only' instead of 'No override' #1895

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix for #1886 - failure_detection is reported as 'link_status_only' instead of 'No override' #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d2d7f56
Fix for #1886
andrei-marinache Oct 25, 2023
d32b0ab
Add changelogs fragment
andrei-marinache Oct 25, 2023
7821efa
Rename 1895_ to 1886_fix_vmware_portgroup_info
andrei-marinache Oct 25, 2023
d0fca12
Rename 1886_fix_vmware_portgroup_info to 1886_fix_vmware_portgroup_in…
andrei-marinache Oct 25, 2023
d08ce7d
Merge branch 'ansible-collections:main' into main
andrei-marinache Oct 25, 2023
69638e0
Update changelogs fragment
andrei-marinache Oct 25, 2023
89beb8b
Updated changelog fragment
andrei-marinache Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/1886_fix_vmware_portgroup_info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- vmware_portgroup_info - fix issue when failure_detection is reported as 'link_status_only' instad of 'No override'
2 changes: 1 addition & 1 deletion plugins/modules/vmware_portgroup_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def normalize_pg_info(portgroup_obj, policy_info):
else:
pg_info_dict['failover_active'] = spec.policy.nicTeaming.nicOrder.activeNic
pg_info_dict['failover_standby'] = spec.policy.nicTeaming.nicOrder.standbyNic
if spec.policy.nicTeaming.failureCriteria is None:
if spec.policy.nicTeaming.failureCriteria is None or spec.policy.nicTeaming.failureCriteria.checkBeacon is None:
pg_info_dict['failure_detection'] = "No override"
else:
if spec.policy.nicTeaming.failureCriteria.checkBeacon:
Expand Down