-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snc 39010 interface enhancement port group speed error handling #487
Open
awhaley-dell
wants to merge
9
commits into
ansible-collections:main
Choose a base branch
from
awhaley-dell:SNC-39010_interface_enhancement_port-group_speed_error_handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface in a port-group fails to have its speed configured correctly
… tables, and adding a valid speed check helper function
stalabi1
reviewed
Jan 24, 2025
plugins/module_utils/network/sonic/config/interfaces/interfaces.py
Outdated
Show resolved
Hide resolved
…s.py Good point. Co-authored-by: stalabi1 <[email protected]>
…ncement_port-group_speed_error_handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding port-group validation before configuring speeds to better report incorrect configurations and communicate the features limitations.
ISSUE TYPE
COMPONENT NAME
interfaces
OUTPUT
interface_invalid_speed_change_default_port-group.log
interface_invalid_speed_change_non-default_port-group.log
interface_valid_speed_change_default_port-group.log
interface_valid_speed_change_non-default_port-group.log
ADDITIONAL INFORMATION
Added helper functions in interfaces_util to pre-check valid speeds and enhance error reporting for a given interface.
Valid speed configurations are allowed and invalid speed configurations throw errors detailing port-group rules and showing valid speeds vs what was given.
Note: Final error message may change slightly for clarity from review feedback.
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Test valid configuration of a member of a port-group in a default state
Test invalid configuration of a member of a port-group in a default state
Test valid configuration of a member of a port-group in a non-default state
Test invalid configuration of a member of a port-group in a non-default state