Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified vcenter_vm_customize test to run on real vCenter #577

Conversation

anna-savina
Copy link
Collaborator

Modified vcenter_vm_customize test to run on real vCenter

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (4a41c63) to head (c631f49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   37.04%   37.04%           
=======================================
  Files         145      145           
  Lines       11398    11398           
  Branches     2262     2262           
=======================================
  Hits         4222     4222           
  Misses       7176     7176           
Flag Coverage Δ
sanity 37.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anna-savina anna-savina force-pushed the modify_vcenter_vm_customize_test branch from affb71e to 2d25c61 Compare January 2, 2025 13:03
Copy link
Contributor

@shellymiron
Copy link
Collaborator

nice PR! I liked what you did with the general vm creation from template & resource pool
we can integrate it later to other tests aswell

Copy link
Collaborator

@prabinovRedhat prabinovRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anna-savina anna-savina force-pushed the modify_vcenter_vm_customize_test branch from 2d25c61 to c631f49 Compare January 2, 2025 13:42
@anna-savina
Copy link
Collaborator Author

nice PR! I liked what you did with the general vm creation from template & resource pool we can integrate it later to other tests aswell

yes, it was my plan for future :)

Copy link
Contributor

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/35416c297baa43e9bdf3e3fb9220fa42

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 08s
✔️ build-ansible-collection SUCCESS in 7m 34s
✔️ ansible-galaxy-importer SUCCESS in 3m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a1a027d into ansible-collections:main Jan 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants