Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant libraryitems example modules #580

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OrrBG
Copy link
Contributor

@OrrBG OrrBG commented Jan 12, 2025

SUMMARY

remove redundant vcenter_vmtemplate_libraryitems example modules

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vcenter_vmtemplate_libraryitems

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (00b7a43) to head (a085216).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   37.04%   37.04%           
=======================================
  Files         145      145           
  Lines       11398    11398           
  Branches     2262     2262           
=======================================
  Hits         4222     4222           
  Misses       7176     7176           
Flag Coverage Δ
sanity 37.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Comment on lines -395 to -403
- name: Get the list of items of the NFS library
vmware.vmware.content_library_item_info:
library_id: '{{ nfs_lib.id }}'
register: lib_items

- name: Use the name to identify the item
set_fact:
my_template_item: "{{ lib_items.value | selectattr('name', 'equalto', 'golden-template')|first }}"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tasks are needed for the next task. my_template_item is used.

itd be better if you could just use the output from the first time vcenter_vmtemplate_libraryitems is called, but I am not sure thats possible. Youll have to test it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants