Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the pipelines #13

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Fix for the pipelines #13

merged 8 commits into from
Oct 24, 2024

Conversation

mabulgu
Copy link

@mabulgu mabulgu commented Oct 23, 2024

Description

This PR fixes several issues like the Containerfile's not having a target as "production" and the usage of requirements.txt file which doesn't exist in the project anymore (A PR for this is opened to the usptream project as well: road-core#76).

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

The PR already tests the PR pipeline. The push pipeline can be tested when this PR is merged.

@mabulgu mabulgu changed the title [Draft] Fix for the push pipeline Fix for the pipelines Oct 23, 2024
@mabulgu mabulgu marked this pull request as ready for review October 23, 2024 20:28
Copy link

@justjais justjais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mabulgu mabulgu merged commit 3819b40 into main Oct 24, 2024
18 checks passed
@jameswnl jameswnl deleted the fix/push-pipeline branch October 31, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants