Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of tox-gh-action #74

Closed
wants to merge 1 commit into from
Closed

Make use of tox-gh-action #74

wants to merge 1 commit into from

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 6, 2021

No description provided.

@ssbarnea ssbarnea force-pushed the fix/gha branch 2 times, most recently from 2b8f589 to 49fb779 Compare September 6, 2021 16:21
@ssbarnea ssbarnea changed the title WIP test GHA warnings Make use of tox-gh-action Sep 6, 2021
@ssbarnea
Copy link
Member Author

ssbarnea commented Sep 6, 2021

@webknjaz WDYT about that? Apparently grouping works but there are 4-5 lines that seem to not be part of the groups:

py36-devel recreate: /home/runner/work/ansible-compat/ansible-compat/.tox/py36-devel
py36-devel installdeps: ansible-core @ git+https://github.com/ansible/ansible.git
py36-devel develop-inst: /home/runner/work/ansible-compat/ansible-compat
py36-devel installed: ...

It is bit annoying but not a big deal. Another question is around "recreate", i am not sure why I see recreate as the environment is already created at previous step and this action should not even run.

@webknjaz
Copy link
Member

webknjaz commented Sep 6, 2021

Another question is around "recreate", i am not sure why I see recreate as the environment is already created at previous step and this action should not even run.

This often depends on a combination of different args you set up when running tox. Sometimes it's a bug. Try checking the old tox runs to see if it's there too.

@ssbarnea
Copy link
Member Author

ssbarnea commented Sep 7, 2021

@webknjaz Take a look at https://github.com/ansible-community/ansible-compat/pull/74/checks?check_run_id=3526660101

I think that is a proof that tox-gh-action fails on making the UI easier to use. The errored group is collapsed, not even visible from current screen and requires considerable scrolling in order to find an expand. Shortly that makes the entire plugin pretty much useless. I will raise it as bug, with the hope that some changes can be made to improve the output.

Blocked by ymyzk/tox-gh-actions#80 and ymyzk/tox-gh-actions#57

@ssbarnea
Copy link
Member Author

I will drop this endeavor as I do not like author action regarding adoption and I know that tox maintainer is already working on an action that will be released alongside tox v4.

It is better for us to wait till tox 4v is out.

@ssbarnea ssbarnea closed this Sep 16, 2021
@ssbarnea ssbarnea deleted the fix/gha branch March 16, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants