[stable-4.9] Allow HUB_UI_VERSION to point to a tag name #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously this assumed HUB_UI_VERSION would always use the commit sha, when run with a tag name, the link in about modal would lead to the wrong place this allows for both sha or tag name (as long as the tag name contains a dot) Issue: AAP-34966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAP-34966
Closes: #5292
previously the About modal assumed HUB_UI_VERSION would always use the commit sha, when run with a tag name, the link in about modal would lead to the wrong place
this allows for both sha or tag name (as long as the tag name contains a dot)