Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added pg_notify #616

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: added pg_notify #616

merged 1 commit into from
Jan 18, 2024

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Nov 6, 2023

Added an action to send notifications via postgres LISTEN/NOTIFY

This feature requires an updated ansible.eda collection with the pg_listener source plugin

Using this branch you can create an image with the new collection and push it to your private quay.io repo

This will ensure that your image has the latest collection which can use the pg_listener source plugin in a rulebook.

@mkanoor mkanoor marked this pull request as draft November 6, 2023 23:18
@mkanoor mkanoor force-pushed the pg_pub_sub_action branch 4 times, most recently from afbd612 to 685647b Compare November 20, 2023 18:38
@mkanoor mkanoor marked this pull request as ready for review November 20, 2023 19:23
@mkanoor mkanoor force-pushed the pg_pub_sub_action branch 3 times, most recently from acfadb3 to b4ceef3 Compare November 22, 2023 17:35
@mkanoor mkanoor force-pushed the pg_pub_sub_action branch 3 times, most recently from ad6debe to 8418881 Compare December 20, 2023 22:33
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@mkanoor mkanoor force-pushed the pg_pub_sub_action branch 2 times, most recently from 42a7720 to 68ba062 Compare January 11, 2024 20:18
Alex-Izquierdo
Alex-Izquierdo previously approved these changes Jan 12, 2024
Copy link
Contributor

@Alex-Izquierdo Alex-Izquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a suggestion for an enhancement, the chunk logic can be encapsulated in a separate function, and it can have its own unit tests to ensure that the chunk logic works as expected.

Alex-Izquierdo
Alex-Izquierdo previously approved these changes Jan 12, 2024
Copy link
Contributor

@Alex-Izquierdo Alex-Izquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alex-Izquierdo
Alex-Izquierdo previously approved these changes Jan 12, 2024
Added an action to send notifications via postgres LISTEN/NOTIFY
@mkanoor mkanoor merged commit 008639e into ansible:main Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants