HostMetrics: Hard auto-cleanup #14255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slemrmartin
force-pushed
the
host-metrics-cleanup
branch
2 times, most recently
from
4a7df3f to
ec8d34d
Compare
|
@AlanCoding ready for review. |
AlanCoding
reviewed
Jul 26, 2023
AlanCoding
reviewed
Aug 3, 2023
AlanCoding
reviewed
Aug 3, 2023
AlanCoding
reviewed
Aug 3, 2023
AlanCoding
reviewed
Aug 3, 2023
AlanCoding
reviewed
Aug 3, 2023
AlanCoding
reviewed
Aug 3, 2023
AlanCoding
reviewed
Aug 3, 2023
slemrmartin
force-pushed
the
host-metrics-cleanup
branch
4 times, most recently
from
09d541d to
5be38d0
Compare
AlanCoding
approved these changes
Aug 10, 2023
slemrmartin
force-pushed
the
host-metrics-cleanup
branch
from
5be38d0 to
ca42f38
Compare
AlanCoding
reviewed
Aug 24, 2023
awx/main/tests/functional/commands/test_cleanup_host_metrics.py
Outdated
Show resolved
Hide resolved
AlanCoding
reviewed
Aug 28, 2023
| - - updates columns delete, deleted_counter and last_deleted | ||
| - hard cleanup | ||
| - - Permanently erase from the database all host metrics last automated 36 months ago or before. | ||
| This operation happens after the soft deletion has finished. | ||
| """ |
There was a problem hiding this comment.
What if you tried assigning this docstring to a help variable as in the Django docs?
https://docs.djangoproject.com/en/4.2/howto/custom-management-commands/
There was a problem hiding this comment.
@AlanCoding we discussed that previously. The help variable is here below docstring and should be one-liner.
It's not supposed to be long description like the docstring (also according to the doc you posted ^)
slemrmartin
force-pushed
the
host-metrics-cleanup
branch
from
c8e5fcc to
112bb15
Compare
slemrmartin
force-pushed
the
host-metrics-cleanup
branch
from
112bb15 to
f606e7c
Compare
|
QA Approved! |
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
Fix host metric settings Cleanup_host_metric command with default params Fix order of host metric cleanups
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
Fix host metric settings Cleanup_host_metric command with default params Fix order of host metric cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Extends
cleanup_host_metrics(HostMetrics cleanup task and more Subscription info #13764) andawx-manage cleanup_host_metricsfor deleting of HostMetric rows which were soft-deleted 3+ years ago and wasn't reused for automation.
https://issues.redhat.com/browse/AA-1592
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
It's part of ADR0017 - will be backported