Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the license module requires fetching subs prior #14351

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

phess
Copy link
Contributor

@phess phess commented Aug 16, 2023

SUMMARY

The awx.license module requires accessing a Red Hat Satellite or web-based Red Hat Subscription Management servers. However, the awx.license module itself won't use these parameters. Instead, the awx.subscriptions module should be used for querying Red Hat Satellite or Red Hat Subscription Management servers for a list of subscriptions at some point prior to awx.license.

This PR adds an example to the Examples section to clarify that the awx.subscriptions module should be used prior to awx.license.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Collection
  • Docs
AWX VERSION

Collection version: awx.awx==22.7.0

ADDITIONAL INFORMATION

none

@github-actions github-actions bot added component:awx_collection issues related to the collection for controlling AWX community labels Aug 16, 2023
@phess
Copy link
Contributor Author

phess commented Aug 16, 2023

Hi @john-westcott-iv , this is the change we talked about.
I'm only adding the example to the license module so as to make this change minimal.
Personally, I think an additional note in the "Notes" section of the online documentation would also be nice but I don't think the "Notes" section is encoded inside the module itself and I couldn't find where to add it. Please let me know if you agree with adding a note to "Notes" and whether this can be done inside this repo and this PR.

@rebeccahhh
Copy link
Member

John thinks this is great (I asked him) so I'm merging it.

@rebeccahhh rebeccahhh merged commit b55a099 into ansible:devel Aug 23, 2023
15 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants