Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection token removal, add entry as breaking change #15653

Closed
wants to merge 1 commit into from
Closed

Collection token removal, add entry as breaking change #15653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion awx_collection/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ The following notes are changes that may require changes to playbooks:
- The `notification_configuration` parameter of `tower_notification_template` has changed from a string to a dict. Please use the `lookup` plugin to read an existing file into a dict.
- `tower_credential` no longer supports passing a file name to `ssh_key_data`.
- The HipChat `notification_type` has been removed and can no longer be created using the `tower_notification_template` module.
- Lookup plugins now always return a list, and if you want a scalar value use `lookup` as opposed to `query`
- Lookup plugins now always return a list, and if you want a scalar value use `lookup` as opposed to `query`.
- Removed `oauth_token` as an option for authentication. Internal logic no longer creates a token if given username and password.

## Running Unit Tests

Expand Down
3 changes: 2 additions & 1 deletion awx_collection/tools/roles/template_galaxy/templates/README.md.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ The following notes are changes that may require changes to playbooks:
- The `notification_configuration` parameter of `tower_notification_template` has changed from a string to a dict. Please use the `lookup` plugin to read an existing file into a dict.
- `tower_credential` no longer supports passing a file name to `ssh_key_data`.
- The HipChat `notification_type` has been removed and can no longer be created using the `tower_notification_template` module.
- Lookup plugins now always return a list, and if you want a scalar value use `lookup` as opposed to `query`
- Lookup plugins now always return a list, and if you want a scalar value use `lookup` as opposed to `query`.
- Removed `oauth_token` as an option for authentication. Internal logic no longer creates a token if given username and password.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this already on line 72, not sure how we want to handle this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yeah, I didn't see that. Oh, and on line 79 as well.


{% if collection_package | lower() == "awx" %}
## Running Unit Tests
Expand Down
Loading