-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DAB service redirect auth #2252
Conversation
fca8840
to
e39a566
Compare
DAB is on a devel pin: Lines 113 to 117 in 08dc2d6
|
the dab_jwt tests failing look like:
that might maybe be okay?? |
@elyezer please review |
In ldap check, looks like 1 failure
|
3947918
to
4e5f66a
Compare
No-Issue Special var to satify linter with long name Remove the reverse sync setting temporarily
4e5f66a
to
430665c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming that this will only take effect if the resource server is defined and enabled.
Following @elyezer comment,
I agree, the current code is adding for any install using keycloak or social_auth (the latest affects community galaxy) I think it is better to change it to be conditional on RESOURCE_SERVER |
I agree, yes, this is the structure we want for the overall topic of settings enablement of these. But I believe we are already doing this on the level of logic within the method here: if (not getattr(settings, 'ENABLE_SERVICE_BACKED_SSO', False)) or (not resource_server_defined()):
return None The method You could also exclude the entry based (or not) in the settings definition logic (this code), but that doesn't seem necessary to me since this is also specific to certain scenarios. |
What is this PR doing:
Internal reference AAP-30011
These will be used later, but we believe it is formulated in a way that won't interfere with other deployments.
The social auth class is described in:
https://github.com/ansible/django-ansible-base/blob/devel/docs/apps/service_backed_sso.md
No-Issue
Reviewers must know:
Specifically, the reverse-sync setting change is made okay by this change in DAB
ansible/django-ansible-base@2af5f34#diff-8623b469b6e5d0b1173a741c5702169d5a06e643a8d416c860127373d662217d