[WIP]Update close method to cpdef #122
Conversation
ganeshrn
changed the title
| def __del__(self): | ||
| self.close() |
There was a problem hiding this comment.
Why do you think it's better to use __del__ in Python-land?
| @@ -46,7 +46,7 @@ cdef int _process_outputs(libssh.ssh_session session, | |||
| return len | |||
|
|
|||
| cdef class Channel: | |||
| def __cinit__(self, session): | |||
|
@ganeshrn what is it that you're trying to fix here? |
|
@ganeshrn is this still relevant? |
webknjaz
force-pushed
the
close_fix
branch
2 times, most recently
from
169ed04
to
aa1ad0a
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Define ``close()`` as ``cpdef``
|
@Jakuje would you mind looking into this patch? I'm not able to figure out the motivation behind it, but perhaps you could? |
Sorry, I have no idea. It looks like just moving things around without good explanation. Given that we did not hear from the reporter for 4 years, I would not bother. |
SUMMARY
Define
close()ascpdefISSUE TYPE
ADDITIONAL INFORMATION