Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent SEGFAULTs on consecutive exec_command() invocations #658

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Prevent SEGFAULTs on consecutive exec_command() invocations #658

wants to merge 3 commits into from

Commits on Nov 20, 2024

  1. channels: Avoid reusing stack-local variables for callbacks 

    Previously, stack-local variables hold the callbacks. This
worked as long as the call stack was not overridden by other
function calls or as long as the server closed the channel
very early. In other cases, the delayed close in libssh
could result in calling the callbacks even after we believed
the channel was freed, causing invalid memory access and crashes.

Fixes ansible#57

Signed-off-by: Jakub Jelen <[email protected]>
    @Jakuje
    Jakuje committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9ea5497 View commit details
    Browse the repository at this point in the history

  2. tests: Adjusted reproducer for ansible#57 

    Removes the failed marker as it works now.

Signed-off-by: Jakub Jelen <[email protected]>
    @Jakuje
    Jakuje committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    61da542 View commit details
    Browse the repository at this point in the history

  3. Add changelog 

    Signed-off-by: Jakub Jelen <[email protected]>
    @Jakuje
    Jakuje committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    566ab40 View commit details
    Browse the repository at this point in the history