-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
28 changed files
with
1,017 additions
and
965 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,4 +32,4 @@ jobs: | |
|
|
||
| - name: Run tests | ||
| run: | | ||
| make test | ||
| make testacc | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,74 @@ | ||
| linters: | ||
| enable-all: true | ||
| linters-settings: | ||
| goconst: | ||
| min-len: 2 | ||
| min-occurrences: 3 | ||
| gocyclo: | ||
| min-complexity: 20 | ||
| gosec: | ||
| excludes: | ||
| - G402 | ||
| govet: | ||
| check-shadowing: true | ||
| settings: | ||
| printf: | ||
| funcs: | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf | ||
| lll: | ||
| line-length: 160 | ||
| misspell: | ||
| locale: US | ||
| nolintlint: | ||
| allow-unused: false # report any unused nolint directives | ||
| require-explanation: false # don't require an explanation for nolint directives | ||
| require-specific: false # don't require nolint directives to be specific about which linter is being skipped | ||
| revive: | ||
| rules: | ||
| - name: unexported-return | ||
| disabled: true | ||
| - name: unused-parameter | ||
| stylecheck: | ||
| checks: ["all", "-ST1000", "-ST1003", "-ST1016", "-ST1020", "-ST1021", "-ST1022"] | ||
|
|
||
| disable: | ||
| # Abandoned, replaced by `unused`. | ||
| - deadcode | ||
| # Checks if package imports are in a list of acceptable packages. | ||
| - depguard | ||
| # Forces to handle more cases. | ||
| - exhaustivestruct # Deprecated, replaced by check below. | ||
| - exhaustruct | ||
| # Drop-in replacement of `golint`. | ||
| - revive | ||
| - golint | ||
| # Deprecated. | ||
| - ifshort | ||
| - interfacer | ||
| # Deprecated. Use govet `fieldalignment`. | ||
| - maligned | ||
| # Deprecated. Replaced by `revive`. | ||
| - nosnakecase | ||
| - scopelint | ||
| - structcheck | ||
| - varcheck | ||
| # Imports order | ||
| - gci | ||
| - funlen | ||
| # Tool for code clone detection. | ||
| - dupl | ||
| - rowserrcheck | ||
| - sqlclosecheck | ||
| # Finds wasted assignment statements. | ||
| - wastedassign | ||
| # Deeply nested if statements. | ||
| - nestif | ||
| # Same as `cyclop` linter. | ||
| - gocognit | ||
| linters: | ||
| disable-all: true | ||
| enable: | ||
| - dogsled | ||
| - errcheck | ||
| - exportloopref | ||
| - gocheckcompilerdirectives | ||
| - gochecknoinits | ||
| - goconst | ||
| - gocritic | ||
| - gocyclo | ||
| - cyclop | ||
| - gofmt | ||
| - goimports | ||
| - gomnd | ||
| - goprintffuncname | ||
| - gosec | ||
| - gosimple | ||
| - govet | ||
| - ineffassign | ||
| - lll | ||
| - misspell | ||
| - nakedret | ||
| - noctx | ||
| - nolintlint | ||
| - revive | ||
| - staticcheck | ||
| - stylecheck | ||
| - typecheck | ||
| - unconvert | ||
| - unparam | ||
| - unused | ||
| - whitespace | ||
|
|
||
| issues: | ||
| # Excluding configuration per-path, per-linter, per-text and per-source | ||
| exclude-rules: [] | ||
|
|
||
| run: | ||
| timeout: 5m | ||
| skip-dirs: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| build: | ||
| go build -o terraform-provider-ansible | ||
|
|
||
| test: build | ||
| cd tests/terraform_tests && ./run_tftest.sh | ||
| testacc: | ||
| TF_ACC=1 go test -v ./... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| minor_changes: | ||
| - Code refactoring in order for the provider to be easier to test. Aggregate redundant functions into `utils.go` (https://github.com/ansible/terraform-provider-ansible/pull/110). | ||
| - Add unit tests for critical functions (https://github.com/ansible/terraform-provider-ansible/pull/110). | ||
| - Replace integration tests by acceptance tests, this is the Terraform recommended way for testing providers (https://github.com/ansible/terraform-provider-ansible/pull/110). | ||
| bugfixes: | ||
| - resource/ansible_playbook - On `resourcePlaybookUpdate()` function, remove the call to the `Wait()` function as the command is start using `CombinedOutput` (https://github.com/ansible/terraform-provider-ansible/pull/110). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.