Additional logging when proxy block requests to lightspeed #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested changes
Aug 2, 2024
There was a problem hiding this comment.
This change works against #1481 -- we need to use a different logging mechanism than console log for the service, specialized file logger?
If by any chance you can work towards addressing that problem first, it would very useful.
ssbarnea
changed the title
ssbarnea
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1437 for token exchange blocked by proxy. Debugging the response body for requests to Lightspeed when they fail help us quickly pinpoint if the request is failing when it hits our service or if it is being rejected by the proxy.