Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: section ids with search #586

Merged
merged 6 commits into from
Nov 21, 2024
Merged

fix: section ids with search #586

merged 6 commits into from
Nov 21, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Nov 18, 2024

fix #579

@github-actions github-actions bot added the fix Pull requests related to resolving problems or errors label Nov 18, 2024
@Revathyvenugopal162
Copy link
Contributor Author

testing with ansys/grantami-bomanalytics#644

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review November 18, 2024 16:18
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner November 18, 2024 16:18
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Nov 18, 2024
@Revathyvenugopal162 Revathyvenugopal162 added this to the v1.3 milestone Nov 18, 2024
@jorgepiloto
Copy link
Member

Checking this in ansys/pydpf-core#1846

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for PyDPF. @da1910, could you confirm this branch is also working for your project?

@jorgepiloto
Copy link
Member

@da1910 Confirmed that this is working for their projects. Let's merge it and perform a patch release, @Revathyvenugopal162.

@jorgepiloto jorgepiloto merged commit 1bbd4c5 into main Nov 21, 2024
21 checks passed
@jorgepiloto jorgepiloto deleted the fix/search branch November 21, 2024 09:41
@Revathyvenugopal162
Copy link
Contributor Author

@da1910 Confirmed that this is working for their projects. Let's merge it and perform a patch release, @Revathyvenugopal162.

sure, thanks Jorge, doing the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests related to resolving problems or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in ansys/doc-build@v8
4 participants