Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing DynamicScrapper #198

Merged
merged 43 commits into from
Feb 21, 2024
Merged

Fixing DynamicScrapper #198

merged 43 commits into from
Feb 21, 2024

Conversation

clatapie
Copy link
Collaborator

@clatapie clatapie commented Oct 2, 2023

Closes #197.

@clatapie clatapie linked an issue Oct 2, 2023 that may be closed by this pull request
@ansys-reviewer-bot
Copy link

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@clatapie clatapie self-assigned this Oct 2, 2023
@github-actions github-actions bot added maintenance Package and maintenance related CI/CD documentation Improvements or additions to documentation labels Oct 2, 2023
@github-actions github-actions bot removed the CI/CD label Oct 3, 2023
@clatapie
Copy link
Collaborator Author

clatapie commented Oct 5, 2023

The issue seems to come from a cache.

@github-actions github-actions bot added the CI/CD label Feb 21, 2024
@github-actions github-actions bot added CI/CD and removed CI/CD labels Feb 21, 2024
@github-actions github-actions bot added CI/CD and removed CI/CD labels Feb 21, 2024
Co-authored-by: Roberto Pastor Muela <[email protected]>
@github-actions github-actions bot added CI/CD and removed CI/CD labels Feb 21, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks @clatapie

@github-actions github-actions bot added CI/CD and removed CI/CD labels Feb 21, 2024
@github-actions github-actions bot added CI/CD and removed CI/CD labels Feb 21, 2024
@github-actions github-actions bot added CI/CD and removed CI/CD labels Feb 21, 2024
@clatapie clatapie enabled auto-merge (squash) February 21, 2024 16:01
@clatapie clatapie enabled auto-merge (squash) February 21, 2024 16:03
@github-actions github-actions bot added CI/CD and removed CI/CD labels Feb 21, 2024
@clatapie clatapie merged commit 4d8b232 into main Feb 21, 2024
21 checks passed
@clatapie clatapie deleted the doc/fix-dynamicscrapper branch February 21, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DynamicScrapper
2 participants