Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dosctrings for DataSources #1808

Merged
merged 49 commits into from
Feb 28, 2025
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
765f41d
restart the changes: DataSources class typehints and description
luisaFelixSalles Oct 15, 2024
9e2ef48
restauring pauls pipeline checks changes
luisaFelixSalles Oct 15, 2024
c0f63fb
:?
luisaFelixSalles Oct 15, 2024
8c05453
type hint?
luisaFelixSalles Oct 15, 2024
1a879de
data sources class updated
luisaFelixSalles Oct 16, 2024
0466069
erase my local build
luisaFelixSalles Oct 16, 2024
a9f9c37
restart the changes: DataSources class typehints and description
luisaFelixSalles Oct 15, 2024
ddda88e
restauring pauls pipeline checks changes
luisaFelixSalles Oct 15, 2024
77bbb3d
:?
luisaFelixSalles Oct 15, 2024
340eea0
type hint?
luisaFelixSalles Oct 15, 2024
819e582
data sources class updated
luisaFelixSalles Oct 16, 2024
6b191d6
erase my local build
luisaFelixSalles Oct 16, 2024
573f930
re-restauring pauls pipelines changes
luisaFelixSalles Oct 17, 2024
976fc45
Merge remote-tracking branch 'origin/api/api-ref-data-sources_fix_err…
luisaFelixSalles Oct 17, 2024
0ec7a40
Update .github/workflows/docs.yml
PProfizi Oct 18, 2024
0819701
Update .github/workflows/docs.yml
PProfizi Oct 18, 2024
f865ad3
changes in the set_result_file_path function
luisaFelixSalles Oct 21, 2024
80524d6
Merge remote-tracking branch 'origin/api/api-ref-data-sources_fix_err…
luisaFelixSalles Oct 21, 2024
060cbc5
changes in the guess_result_key function
luisaFelixSalles Oct 21, 2024
ff7c0ba
changes in the guess_second_key function
luisaFelixSalles Oct 21, 2024
5b5f306
changes in the set_domain_result_file_path function
luisaFelixSalles Oct 21, 2024
15b624e
changes in the add_file path and add_domain_file_path functions
luisaFelixSalles Oct 21, 2024
3eb4157
changes in the add_upstream path and add_domain_file_path functions
luisaFelixSalles Oct 21, 2024
f738317
changes in the add_upstream_for_domain function
luisaFelixSalles Oct 22, 2024
fec71a1
changes in the result_key property method
luisaFelixSalles Oct 22, 2024
9a9ab89
changes in the result_files property method
luisaFelixSalles Oct 22, 2024
46175a7
changes in the register_namespace function
luisaFelixSalles Oct 22, 2024
8d25a7a
changes in the add_file_path_for_specific_result function
luisaFelixSalles Oct 22, 2024
0b4f14d
all tests
luisaFelixSalles Oct 22, 2024
eda1365
Merge branch 'master' into api/api-ref-data-sources_fix_error
luisaFelixSalles Oct 23, 2024
0fe509f
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
0465ca8
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
fbba631
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
81b91d8
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
13053c0
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
904c827
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
8f9982f
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
8f0dbaf
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
0894b86
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
18b15cf
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
6021789
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
0a758f9
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
ec0d7d2
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
cdbfc37
Update src/ansys/dpf/core/data_sources.py
luisaFelixSalles Oct 23, 2024
de92eaa
Merge with master
PProfizi Feb 19, 2025
cdb5302
Updates
PProfizi Feb 20, 2025
0f45995
Fix docstring example for DataSources.add_upstream_for_domain()
PProfizi Feb 20, 2025
2fbc9f2
Fix docstring example for DataSources.add_upstream_for_domain()
PProfizi Feb 20, 2025
ee7cc3b
Fix expected paths in docstring examples
PProfizi Feb 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
356 changes: 178 additions & 178 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,82 +68,82 @@ jobs:
echo "suffix=$suffix" >> "$GITHUB_OUTPUT"
fi
echo "branch suffix is: >$suffix<"

style:
name: "Style Check"
runs-on: ubuntu-latest
steps:
- uses: ansys/actions/code-style@v8
with:
use-python-cache: false

build_linux1:
name: "Build linux1 wheel"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: "Install requirements"
run: pip install -r requirements/requirements_build.txt

- name: "Build the manylinux1 wheel"
shell: bash
id: wheel
run: |
python .ci/build_wheel.py -p manylinux1
cd dist
export name=`ls ansys_dpf_core*.whl`
echo ${name}
echo "wheel_name=${name[0]}" >> $GITHUB_OUTPUT
cd ..

- name: "Upload wheel any as artifact"
uses: actions/upload-artifact@v4
with:
name: ${{ steps.wheel.outputs.wheel_name }}
path: dist/${{ steps.wheel.outputs.wheel_name }}

tests:
uses: ./.github/workflows/tests.yml
needs: pick_server_suffix
with:
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
python_versions: '["3.9"]'
wheel: true
wheelhouse: false
standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
secrets: inherit

tests_any:
uses: ./.github/workflows/tests.yml
needs: pick_server_suffix
with:
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
python_versions: '["3.9"]'
wheel: true
wheelhouse: false
standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
test_any: true
secrets: inherit

docker_tests:
name: "Build and Test on Docker"
uses: ./.github/workflows/test_docker.yml
needs: pick_server_suffix
with:
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
secrets: inherit

docker_examples:
name: "Run examples on Docker"
uses: ./.github/workflows/examples_docker.yml
needs: pick_server_suffix
with:
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
python_versions: '["3.9"]'
standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
secrets: inherit
#
# style:
# name: "Style Check"
# runs-on: ubuntu-latest
# steps:
# - uses: ansys/actions/code-style@v8
# with:
# use-python-cache: false
#
# build_linux1:
# name: "Build linux1 wheel"
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
#
# - name: "Install requirements"
# run: pip install -r requirements/requirements_build.txt
#
# - name: "Build the manylinux1 wheel"
# shell: bash
# id: wheel
# run: |
# python .ci/build_wheel.py -p manylinux1
# cd dist
# export name=`ls ansys_dpf_core*.whl`
# echo ${name}
# echo "wheel_name=${name[0]}" >> $GITHUB_OUTPUT
# cd ..
#
# - name: "Upload wheel any as artifact"
# uses: actions/upload-artifact@v4
# with:
# name: ${{ steps.wheel.outputs.wheel_name }}
# path: dist/${{ steps.wheel.outputs.wheel_name }}
#
# tests:
# uses: ./.github/workflows/tests.yml
# needs: pick_server_suffix
# with:
# ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
# python_versions: '["3.9"]'
# wheel: true
# wheelhouse: false
# standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
# secrets: inherit
#
# tests_any:
# uses: ./.github/workflows/tests.yml
# needs: pick_server_suffix
# with:
# ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
# python_versions: '["3.9"]'
# wheel: true
# wheelhouse: false
# standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
# test_any: true
# secrets: inherit
#
# docker_tests:
# name: "Build and Test on Docker"
# uses: ./.github/workflows/test_docker.yml
# needs: pick_server_suffix
# with:
# ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
# standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
# secrets: inherit
#
# docker_examples:
# name: "Run examples on Docker"
# uses: ./.github/workflows/examples_docker.yml
# needs: pick_server_suffix
# with:
# ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
# python_versions: '["3.9"]'
# standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
# secrets: inherit

docs:
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
Expand All @@ -155,105 +155,105 @@ jobs:
event_name: ${{ github.event_name }}
secrets: inherit

upload-development-docs:
runs-on: ubuntu-latest
if: ${{ github.ref == 'refs/heads/master' && github.event_name == 'push' }}
needs: [docs]
steps:
- name: "Upload development documentation"
uses: ansys/actions/doc-deploy-dev@v8
with:
cname: ${{ env.DOCUMENTATION_CNAME }}
token: ${{ secrets.GITHUB_TOKEN }}
doc-artifact-name: HTML-doc-ansys-dpf-core.zip
decompress-artifact: true

doc-index-dev:
name: "Deploy dev index docs"
runs-on: ubuntu-latest
needs: upload-development-docs
steps:
- name: "Deploy the latest documentation index"
uses: ansys/actions/doc-deploy-index@v8
with:
cname: ${{ env.DOCUMENTATION_CNAME }}/version/dev
index-name: pydpf-core-vdev
host-url: ${{ vars.MEILISEARCH_HOST_URL }}
api-key: ${{ env.MEILISEARCH_API_KEY }}
doc-artifact-name: HTML-doc-ansys-dpf-core.zip
decompress-artifact: true

examples:
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
uses: ./.github/workflows/examples.yml
needs: pick_server_suffix
with:
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
python_versions: '["3.9"]'
standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
secrets: inherit

retro_242:
name: "retro 242"
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
uses: ./.github/workflows/tests.yml
with:
ANSYS_VERSION: "242"
python_versions: '["3.9"]'
DOCSTRING: false
standalone_suffix: ''
secrets: inherit

retro_241:
name: "retro 241"
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
uses: ./.github/workflows/tests.yml
with:
ANSYS_VERSION: "241"
python_versions: '["3.9"]'
DOCSTRING: false
standalone_suffix: '.sp01'
secrets: inherit

retro_232:
name: "retro 232"
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
uses: ./.github/workflows/tests.yml
with:
ANSYS_VERSION: "232"
python_versions: '["3.9"]'
DOCSTRING: false
standalone_suffix: ''
secrets: inherit

retro_231:
name: "retro 231"
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
uses: ./.github/workflows/tests.yml
with:
ANSYS_VERSION: "231"
python_versions: '["3.9"]'
DOCSTRING: false
secrets: inherit

retro_222:
name: "retro 222"
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
uses: ./.github/workflows/tests.yml
with:
ANSYS_VERSION: "222"
python_versions: '["3.9"]'
DOCSTRING: false
secrets: inherit

pydpf-post:
name: "PyDPF-Post"
if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
uses: ./.github/workflows/pydpf-post.yml
needs: pick_server_suffix
with:
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
post_branch: "master"
standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
test_docstrings: "true"
secrets: inherit
# upload-development-docs:
# runs-on: ubuntu-latest
# if: ${{ github.ref == 'refs/heads/master' && github.event_name == 'push' }}
# needs: [docs]
# steps:
# - name: "Upload development documentation"
# uses: ansys/actions/doc-deploy-dev@v8
# with:
# cname: ${{ env.DOCUMENTATION_CNAME }}
# token: ${{ secrets.GITHUB_TOKEN }}
# doc-artifact-name: HTML-doc-ansys-dpf-core.zip
# decompress-artifact: true
#
# doc-index-dev:
# name: "Deploy dev index docs"
# runs-on: ubuntu-latest
# needs: upload-development-docs
# steps:
# - name: "Deploy the latest documentation index"
# uses: ansys/actions/doc-deploy-index@v8
# with:
# cname: ${{ env.DOCUMENTATION_CNAME }}/version/dev
# index-name: pydpf-core-vdev
# host-url: ${{ vars.MEILISEARCH_HOST_URL }}
# api-key: ${{ env.MEILISEARCH_API_KEY }}
# doc-artifact-name: HTML-doc-ansys-dpf-core.zip
# decompress-artifact: true
#
# examples:
# if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
# uses: ./.github/workflows/examples.yml
# needs: pick_server_suffix
# with:
# ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
# python_versions: '["3.9"]'
# standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
# secrets: inherit
#
# retro_242:
# name: "retro 242"
# if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
# uses: ./.github/workflows/tests.yml
# with:
# ANSYS_VERSION: "242"
# python_versions: '["3.9"]'
# DOCSTRING: false
# standalone_suffix: ''
# secrets: inherit
#
# retro_241:
# name: "retro 241"
# if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
# uses: ./.github/workflows/tests.yml
# with:
# ANSYS_VERSION: "241"
# python_versions: '["3.9"]'
# DOCSTRING: false
# standalone_suffix: '.sp01'
# secrets: inherit
#
# retro_232:
# name: "retro 232"
# if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
# uses: ./.github/workflows/tests.yml
# with:
# ANSYS_VERSION: "232"
# python_versions: '["3.9"]'
# DOCSTRING: false
# standalone_suffix: ''
# secrets: inherit
#
# retro_231:
# name: "retro 231"
# if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
# uses: ./.github/workflows/tests.yml
# with:
# ANSYS_VERSION: "231"
# python_versions: '["3.9"]'
# DOCSTRING: false
# secrets: inherit
#
# retro_222:
# name: "retro 222"
# if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
# uses: ./.github/workflows/tests.yml
# with:
# ANSYS_VERSION: "222"
# python_versions: '["3.9"]'
# DOCSTRING: false
# secrets: inherit
#
# pydpf-post:
# name: "PyDPF-Post"
# if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
# uses: ./.github/workflows/pydpf-post.yml
# needs: pick_server_suffix
# with:
# ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }}
# post_branch: "master"
# standalone_suffix: ${{needs.pick_server_suffix.outputs.suffix}}
# test_docstrings: "true"
# secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
shell: cmd /D /E:ON /V:OFF /C "CALL "{0}""
working-directory: .ci
run: |
build_doc.bat > ..\doc\log.txt && type ..\doc\log.txt 2>&1
build_doc.bat> ..\doc\log.txt && type ..\doc\log.txt 2>&1
timeout-minutes: 60
env:
MEILISEARCH_PUBLIC_API_KEY: ${{ secrets.MEILISEARCH_PUBLIC_API_KEY }}
Expand Down
Loading
Loading