-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: allow Numpy 1.X #626
Conversation
DPF is working on making that upper limit more flexible but setting a minimum of 2.X is pretty constraining |
This will require a follow up patch release |
the Ci/Cd still installs numpy 2.0 This PR will allow the pydyna-solver, pydyna-pre, and pydyna-run submodules to work with numpy 1.x, but not the pydyna-keywords module. maybe we can throw an error in the NEP 29 doesn't indicate an end-of-life date for numpy1, so I guess we have to fix hollerith so it supports both versions, and test both in the ci/cd. I'll file an issue there. |
Works for me. I can add that disclaimer/check. Is there a big limitation on the numpy version for hollerith? |
We might have a bigger issue ... hollerith will force us to install numpy 2.X still whenever we pip install... making the warning totally useless. We need to get that one solved first. |
Agreed. I may need a bit of help there |
This will allow to use Numpy 1.X now... releasing right after CI/CD passes |
Can we not allow NumPy 1.X? This is breaking the rest of the ecosystem @koubaa