Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow Numpy 1.X #626

Merged
merged 5 commits into from
Nov 22, 2024
Merged

build: allow Numpy 1.X #626

merged 5 commits into from
Nov 22, 2024

Conversation

RobPasMue
Copy link
Member

Can we not allow NumPy 1.X? This is breaking the rest of the ecosystem @koubaa

@RobPasMue RobPasMue self-assigned this Nov 21, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner November 21, 2024 13:34
@RobPasMue
Copy link
Member Author

ansys/pyansys#764

@RobPasMue
Copy link
Member Author

DPF is working on making that upper limit more flexible but setting a minimum of 2.X is pretty constraining

@RobPasMue RobPasMue requested a review from koubaa November 21, 2024 13:35
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Related with project dependencies maintenance Package and maintenance related labels Nov 21, 2024
@RobPasMue
Copy link
Member Author

This will require a follow up patch release

@koubaa
Copy link
Collaborator

koubaa commented Nov 21, 2024

@RobPasMue

the Ci/Cd still installs numpy 2.0
the problem with numpy 1.x support is with hollerith, it only works with numpy 2.x.

This PR will allow the pydyna-solver, pydyna-pre, and pydyna-run submodules to work with numpy 1.x, but not the pydyna-keywords module. maybe we can throw an error in the __init__.py file of the pydyna-keywords module until hollerith can support both numpy versions?

NEP 29 doesn't indicate an end-of-life date for numpy1, so I guess we have to fix hollerith so it supports both versions, and test both in the ci/cd. I'll file an issue there.

@RobPasMue
Copy link
Member Author

RobPasMue commented Nov 21, 2024

maybe we can throw an error in the __init__.py file of the pydyna-keywords module until hollerith can support both numpy versions?

Works for me. I can add that disclaimer/check. Is there a big limitation on the numpy version for hollerith?

@koubaa
Copy link
Collaborator

koubaa commented Nov 21, 2024

@RobPasMue see ansys/hollerith#34

@RobPasMue
Copy link
Member Author

RobPasMue commented Nov 21, 2024

We might have a bigger issue ... hollerith will force us to install numpy 2.X still whenever we pip install... making the warning totally useless. We need to get that one solved first.

@koubaa
Copy link
Collaborator

koubaa commented Nov 21, 2024

We might have a bigger issue ... hollerith will force us to install numpy 2.X still whenever we pip install... making the warning totally useless. We need to get that one solved first.

Agreed. I may need a bit of help there

pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@RobPasMue
Copy link
Member Author

This will allow to use Numpy 1.X now... releasing right after CI/CD passes

@RobPasMue RobPasMue merged commit 65335c5 into main Nov 22, 2024
28 checks passed
@RobPasMue RobPasMue deleted the build/numpy branch November 22, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants